feat: Implement cross-process lock for the EventCache
#4192
+259
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
force-pushed
the
feat-sdk-event-cache-cross-process-storage
branch
2 times, most recently
from
c5dbe73
to
4e2bea3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4192 +/- ##
==========================================
+ Coverage 84.89% 84.91% +0.02%
==========================================
Files 272 272
Lines 29142 29213 +71
==========================================
+ Hits 24739 24807 +68
- Misses 4403 4406 +3 ☔ View full report in Codecov by Sentry. |
This patch replaces a `&*` by a `.as_ref()` and a `.deref()`. The result is the same but it's just simpler for newcomers to understand what happens.
The idea is to avoid name conflicts when implementing other traits that use the `Error` associated type.
Hywan
force-pushed
the
feat-sdk-event-cache-cross-process-storage
branch
from
12f3ff3
to
666eba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
EventCachestorage #3280