chore(ffi): in Client::account_url return early when we're not an OIDC session
#4191
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idc session This avoids one spammy log for sessions not using oidc.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4191 +/- ##
=======================================
Coverage 84.87% 84.87%
=======================================
Files 271 271
Lines 29076 29076
=======================================
+ Hits 24677 24679 +2
+ Misses 4399 4397 -2 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 30, 2024
Co-authored-by: Damir Jelić <[email protected]> Signed-off-by: Benjamin Bouvier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids one spammy error log for sessions not using oidc.