feat(ffi): add Client::public_rooms function
#4187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oms directory Also add `ffi::PublicRoomsChunk` structure to map the resulting data.
|
Shouldn't this be managed through the existing |
Ah, I didn't realise this already existed since I couldn't find the raw API call being used in the project. Closing this, I'll modify the directory search API then (if possible). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4187 +/- ##
==========================================
+ Coverage 84.87% 84.88% +0.01%
==========================================
Files 271 271
Lines 29076 29076
==========================================
+ Hits 24677 24682 +5
+ Misses 4399 4394 -5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to get rooms from the public rooms directory. Also add
ffi::PublicRoomsChunkstructure to map the resulting data.A customer couldn't find a way to use this feature in their fork because the method wasn't in the FFI layer, so I added it here.
Signed-off-by: