chore(ui,ffi): Remove the RoomList::entries method (reapply #3999)
#4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4083 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 269 269
Lines 28715 28715
=======================================
+ Hits 24311 24312 +1
+ Misses 4404 4403 -1 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
Oct 7, 2024
bnjbvr
changed the title
bnjbvr
changed the title
bnjbvr
changed the title
RoomList::entries method (reapply #3999)
This reverts commit af39032.
Hywan
force-pushed
the
revert-4001-revert-3999-feat-ui-room-list-remove-entries
branch
from
390f6c0
to
295cb45
Compare
Hywan
deleted the
revert-4001-revert-3999-feat-ui-room-list-remove-entries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3999 has been merged, but Complement Crypto was failing. It's been reverted in #4001. Now that Complement Crypto has been fixed (matrix-org/complement-crypto#135), we can restore #3999, hence this PR.