Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui,ffi): Remove the RoomList::entries method (reapply #3999) #4083

Merged

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Oct 7, 2024

#3999 has been merged, but Complement Crypto was failing. It's been reverted in #4001. Now that Complement Crypto has been fixed (matrix-org/complement-crypto#135), we can restore #3999, hence this PR.

@Hywan Hywan requested a review from a team as a code owner October 7, 2024 11:30
@Hywan Hywan requested review from poljar and removed request for a team October 7, 2024 11:30
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (4cbc162) to head (295cb45).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4083   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         269      269           
  Lines       28715    28715           
=======================================
+ Hits        24311    24312    +1     
+ Misses       4404     4403    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan enabled auto-merge (rebase) October 7, 2024 12:11
@bnjbvr bnjbvr changed the title Reapply #3999 chore(ui,ffi): Remove the RoomList::entries method (reapply #3999( Oct 7, 2024
@bnjbvr bnjbvr changed the title chore(ui,ffi): Remove the RoomList::entries method (reapply #3999( chore(ui,ffi): Remove the RoomList::entries method (reapply #3999) Oct 7, 2024
@bnjbvr bnjbvr changed the title chore(ui,ffi): Remove the RoomList::entries method (reapply #3999) chore(ui,ffi): Remove the RoomList::entries method (reapply #3999) Oct 7, 2024
@Hywan Hywan force-pushed the revert-4001-revert-3999-feat-ui-room-list-remove-entries branch from 390f6c0 to 295cb45 Compare October 7, 2024 13:37
@Hywan Hywan merged commit 6f0fbf9 into main Oct 7, 2024
40 checks passed
@Hywan Hywan deleted the revert-4001-revert-3999-feat-ui-room-list-remove-entries branch October 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants