Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #12928 (Report documentation looks a bit odd when there is no docs for a report) #22739

Open
wants to merge 4 commits into
base: 5.x-dev
Choose a base branch
from

Conversation

ilacftemp
Copy link

@ilacftemp ilacftemp commented Nov 6, 2024

Description:

This change addresses the issue where the report documentation appears odd or empty when no documentation is available for a report. Specifically, it ensures that a default message ("No documentation available for this report.") is displayed when reportDocumentation is empty or missing. This improves the user experience by providing clear feedback instead of showing a blank or incomplete UI.

Review

core/Plugin/Controller.php Outdated Show resolved Hide resolved
@ilacftemp
Copy link
Author

I corrected what you asked for! Thanks for the help @michalkleiner! Could you review this PR again, please?

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation string is needed

core/Plugin/Controller.php Show resolved Hide resolved
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please check the PHPCS lint errors and correct those?

@michalkleiner
Copy link
Contributor

Fixes #12928

@ilacftemp
Copy link
Author

Lint errors corrected! :)

@ilacftemp
Copy link
Author

Hi @michalkleiner ! Anything else to correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants