bug: fix overlay container for popout to floating

mathuo · Dec 22, 2024 · 11aadf5 · 11aadf5
1 parent 487d02b
commit 11aadf5
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts
@@ -844,6 +844,10 @@ export class DockviewComponent
                         } else if (this.getPanel(group.id)) {
                             const removedGroup = group;
 
+                            removedGroup.model.renderContainer =
+                                this.overlayRenderContainer;
+                            returnedGroup = removedGroup;
+
                             if (floatingBox) {
                                 this.addFloatingGroup(removedGroup, {
                                     height: floatingBox.height,
@@ -857,10 +861,7 @@ export class DockviewComponent
                                     skipPopoutReturn: true,
                                 });
 
-                                removedGroup.model.renderContainer =
-                                    this.overlayRenderContainer;
                                 removedGroup.model.location = { type: 'grid' };
-                                returnedGroup = removedGroup;
 
                                 this.movingLock(() => {
                                     // suppress group add events since the group already exists