Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension for LaTeX package braket #2029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add extension for LaTeX package braket #2029

wants to merge 1 commit into from

Conversation

swickrotation
Copy link

"braket" is a light LaTeX package that provides macros for typesetting the notational conventions of quantum mechanics

@pkra
Copy link
Contributor

pkra commented Aug 21, 2018

Have you checked https://github.com/mathjax/MathJax/blob/master/CONTRIBUTING.md ? You're not following the folder structure of MathJax and you're working on the wrong branch.

Overall, this looks like you wre trying to make a third party extension, cf. https://docs.mathjax.org/en/latest/options/ThirdParty.html#thirdparty. In that case, it's usually best to start out in a separate repository and publish to npm for distribution (also via CDNs like jsdelivr).

@zorkow
Copy link
Member

zorkow commented Sep 5, 2018

I note that the braket and set macros differ from the LaTeX package, in that they both take two arguments, while the original LaTeX macros only take one argument and use | or || as separators.
Is that intended? I would advise changing the arity of macro in MathJax.

Also in the Braket macro the \middle in front of the \mid seems to be missing.

@swickrotation
Copy link
Author

@zorkow you're right, thanks for the assist. I'm going to make the changes you suggested- they're more correctly in-line with the actual braket TeX package, where as what I've got here is really just personal preference. Doesn't make sense to call it support if the macros aren't the same here as in TeX.

@pkra Thanks for the feedback, I'll be more careful and try to make the right changes, and publish to npm.

Cheers!

@zorkow
Copy link
Member

zorkow commented Sep 25, 2018

I've put together a quick implementation of the braket package (with the expected behaviour) in version 3.
Have a look here.
It's still in its own branch, but should make it into the next beta release.

@JeppeKlitgaard
Copy link

I think this PR can be closed now, as a braket implementation now exists in MathJax v3+ using the braket extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants