Merge pull request #6 from skuhnow/master

feat: make custom fields protected to allow overrides in custom baske…

src/Mathielen/SapOci/Model/OciBaseBasketItem.php

@@ -60,15 +60,15 @@ class OciBaseBasketItem implements OciBasketItemInterface
 
 	private ?string $sldSysName = null;
 
-	private ?string $custField1 = null;
+	protected ?string $custField1 = null;
 
-	private ?string $custField2 = null;
+	protected ?string $custField2 = null;
 
-	private ?string $custField3 = null;
+	protected ?string $custField3 = null;
 
-	private ?string $custField4 = null;
+	protected ?string $custField4 = null;
 
-	private ?string $custField5 = null;
+	protected ?string $custField5 = null;
 
 	public static function create(): self
 	{

tests/unit/Mathielen/SapOci/Model/OciExtendedBasketItemTest.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Mathielen\SapOci\Model;
+
+use PHPUnit\Framework\TestCase;
+
+class OciExtendedBasketItemTest extends TestCase
+{
+
+	public function testSetOverriddenCustomField(): void
+	{
+		$sut = new OciExtendedBasketItem();
+		$testString21Chars = \str_repeat('x', 21);
+		$sut->setCustField4($testString21Chars);
+		$this->assertEquals($testString21Chars, $sut->getCustField4());
+	}
+}
+
+class OciExtendedBasketItem extends OciBaseBasketItem
+{
+	public function setCustField4(?string $custField4 = null): OciBaseBasketItem
+	{
+		$this->custField4 = $custField4;
+
+		return $this;
+	}
+}