call ->info() on LocalFileStorage if used for writing (i.e. file does…

… not exists)
mathielen · Aug 5, 2015 · 1a7aa48 · 1a7aa48
1 parent eb22350
commit 1a7aa48
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/Mathielen/ImportEngine/Storage/LocalFileStorage.php b/src/Mathielen/ImportEngine/Storage/LocalFileStorage.php
@@ -165,12 +165,13 @@ public function getHash()
     public function info()
     {
         if (!isset($this->info)) {
+            $fileExists = $this->file->isReadable();
             $this->info = new StorageInfo(array(
                 'name' => $this->file->getFilename(),
-                'hash' => $this->getHash(),
+                'hash' => $fileExists?$this->getHash():null,
                 'format' => $this->getFormat(),
-                'size' => $this->file->getSize(),
-                'count' => count($this->reader())
+                'size' => $fileExists?$this->file->getSize():0,
+                'count' => $fileExists?count($this->reader()):0
             ));
         }
 

diff --git a/tests/functional/Mathielen/ImportEngine/LocalFileTest.php b/tests/functional/Mathielen/ImportEngine/LocalFileTest.php
@@ -10,6 +10,7 @@
 use Mathielen\ImportEngine\Storage\Format\Format;
 use Mathielen\ImportEngine\Storage\Format\XmlFormat;
 use Mathielen\ImportEngine\Storage\LocalFileStorage;
+use Mathielen\ImportEngine\Storage\StorageInfo;
 use Mathielen\ImportEngine\ValueObject\ImportConfiguration;
 use Mathielen\ImportEngine\ValueObject\ImportRun;
 
@@ -32,6 +33,14 @@ public function testImport($sourceFile, Format $format, Format $targetFormat=nul
         $sourceStorage = new LocalFileStorage(new \SplFileInfo($sourceFile), $format);
         $targetStorage = new LocalFileStorage(new \SplFileInfo($targetFile), $targetFormat);
 
+        $this->assertEquals(new StorageInfo(array(
+            'name' => basename($targetFile),
+            'hash' => null,
+            'format' => $targetFormat,
+            'size' => 0,
+            'count' => 0
+        )), $targetStorage->info());
+
         $importer = Importer::build($targetStorage);
 
         $importConfiguration = new ImportConfiguration();