Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another preliminary for #1350, this adds the very basic topology for sums. There are a lot of results about sums that are missing, of course. Sums preserve uniform and pseudometric structures, and basically all the local properties. But for now I just provide what I need for homotopy theory.
Annoyingly, there is a call to the non-ssreflect tactic
destruct
here, when dealing with dependent equalities. When I have a fact thati = j
, then formexistT P i x = existT P j y
should produce ax = y
. I could not figure how to do this. If thedestruct
tactic is forbidden, then how should I remove it?Checklist
CHANGELOG_UNRELEASED.md
Reference: How to document
Reminder to reviewers