Tentative Nix Fix #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenCyril
reviewed
Jan 22, 2024
.nix/config.nix
Outdated
| @@ -7,7 +7,7 @@ | |||
| ## The attribute to build from the local sources, | |||
| ## either using nixpkgs data or the overlays located in `.nix/coq-overlays` | |||
| ## Will determine the default main-job of the bundles defined below | |||
| attribute = "coq-combi"; | |||
| attribute = "Coq-Combi"; | |||
There was a problem hiding this comment.
If you rename this, you need to rename the overlay
.nix/coq-overlays/coq-combi/default.nix
to
.nix/coq-overlays/Coq-Combi/default.nix
but then you are not respecting the current conventions of nixpkgs (cf https://github.com/NixOS/nixpkgs/blob/master/pkgs/top-level/coq-packages.nix)
There was a problem hiding this comment.
@CohenCyril : Nix and CI seems to work now !!! Thanks a lot for debugging my mess !
There was a problem hiding this comment.
@CohenCyril I manage to get rid of the error, but no test is actually performed ! I purposedly inserted a stupid bla in 3899262 and the CI didn't complain... Sorry.
CohenCyril
reviewed
Jan 22, 2024
Co-authored-by: Cyril Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.