Hw solution1 #1717
Open
Hw solution1 #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Great job on implementing the main functionality! 🎉 While there are a few minor improvements suggested, such as refactoring the static method in ColorSupplier and addressing magic numbers and access modifiers, these don't critically impact the functionality of your code. Keep up the good work and consider these suggestions for future enhancements. Your code is ready to go! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| @@ -1,7 +1,10 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| import java.util.Random; | |||
|
|
|||
| public class ColorSupplier { | |||
There was a problem hiding this comment.
The method getRandomColor is static. According to the checklist, static methods are generally discouraged. Consider refactoring this to an instance method if feasible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.