Add Linux support to the Makefile #64
Conversation
| -v $(shell pwd)/$(BUILDDIR):/tmp/utils/$(BUILDDIR) \ | ||
| bintosyxbuilder \ | ||
| ./tools/out/bintosyx /pro 000 $(BIN) $(SYX) | ||
| else |
There was a problem hiding this comment.
Interested in your thoughts on having macOS build the bintosyx tool via Docker from the other repo as well. The only counter-argument I can think of is that macOS machines don't come with gcc preinstalled (but, anyone tinkering with this on a Mac is likely to have gcc installed anyway).
For Windows I'd avoid using Docker and keep the currently prebuilt EXE because you have to either make VS a requirement or deal with the mess of using gcc on Windows, both of which I'd prefer to avoid in a firmware project.
There was a problem hiding this comment.
I could go either way for Mac, assuming the already provided tools/bintosyx binary has been working. Maybe in another branch, I can experiment with it and let you know what I think.
README.md
Outdated
|
|
||
| #### Flashing | ||
|
|
||
| The MIDI SysEx utility, `amidi`, comes preinstalled on most Linux distributions |
There was a problem hiding this comment.
The recommended way to flash on all platforms is through https://fw.mat1jaczyyy.com, though I suppose a short mention of amidi can be added to the Installation section near the beginning of the readme instead of the full blown explanation.
There was a problem hiding this comment.
Sounds good! Cleared out the full explanation from the README and added amidi to the list at the top.
* Remove full amidi explanation * Add amidi to list of SysEx-capable programs
I've added detection for Linux to the Makefile which will use a Linux container to build and run the bintosyx command. Maybe in the future, the Dockerfile can handle the main build as well.