Apply languageIdentifier attribute to user-generated content where possible #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…es when reading posts in other languages accessibilityLanguage won’t work since the non-content text (such as the date) is in the system default language
kimar
reviewed
May 20, 2023
| @@ -31,6 +31,9 @@ public final class StatusEdit: NSManagedObject { | |||
| // sourcery: autoUpdatableObject, autoGenerateProperty | |||
| @NSManaged public var spoilerText: String? | |||
|
|
|||
| // sourcery: autoUpdatableObject, autoGenerateProperty | |||
| @NSManaged public var status: Status? | |||
There was a problem hiding this comment.
❓ Does the CoreData model already reflect this relationship? I haven't seen any changes to our Model in this PR.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[builds on #880, feel free to merge just this one to get the changes from both]
This allows VoiceOver to dynamically switch voices based on the language a post was written in, without affecting the pronunciation of UI elements. For example, if reading a German post while the device is set to English, the English voice would read the username, date, “# media,” and “Actions available”, while the German voice would read the actual post content. This also applies to alt text (which inherits the language of the post).
It would be nice to also read people’s names and bios in the appropriate language, but that’s blocked on mastodon/mastodon#23067 which I’ve just opened.