feat: adds a complete set of toolbox tasks #6
Conversation
lib/toolbox/Taskfile.yaml
Outdated
| install: | ||
| desc: Install wrapper script from geodesic container | ||
| internal: true | ||
| requires: | ||
| vars: | ||
| - TOOLBOX_NAME | ||
| cmds: | ||
| - docker run --rm {{.REGISTRY_LATEST_URL}} init | bash -s {{.TOOLBOX_NAME}} |
There was a problem hiding this comment.
it's impossible to understand what this task does from the code here. Please add a longer description, or if you can, pull the install wrapper script outside of the container to somewhere that it can be viewed
There was a problem hiding this comment.
Great point -- I'll make this clearer via desc + summary. Thanks for the callout.
lib/toolbox/Taskfile.yaml
Outdated
| run: | ||
| desc: Run our toolbox image while also mounting your $HOME folder to `/localhost` in the container | ||
| deps: | ||
| - install | ||
| cmds: | ||
| - docker run --rm {{.LATEST_IMAGE_TAG}} init | bash -s {{.IMAGE_NAME}} || (echo 'Try "sudo make install"'; exit 1) | ||
| - "{{.TOOLBOX_NAME}}" | ||
|
|
||
| pull: | ||
| desc: Pull our toolbox image from registry | ||
| deps: | ||
| - auth | ||
| requires: | ||
| vars: | ||
| - REGISTRY_URL_BASE | ||
| - REGISTRY_URL_FULL | ||
| - REGISTRY_LATEST_URL | ||
| cmds: | ||
| - | | ||
| aws ecr get-login-password --region $(AWS_REGION) | docker login --username AWS --password-stdin {{.REGISTRY_URL_BASE}} | ||
| docker pull {{.REGISTRY_URL_FULL}} | ||
| - docker pull {{.REGISTRY_LATEST_URL}} | ||
| - docker tag {{.REGISTRY_LATEST_URL}} {{.LATEST_IMAGE_TAG}} |
There was a problem hiding this comment.
move these higher than run:pull and run:build so they can be read chronologically
lib/toolbox/Taskfile.yaml
Outdated
| internal: true | ||
| requires: | ||
| vars: | ||
| - TOOLBOX_NAME |
There was a problem hiding this comment.
| - TOOLBOX_NAME | |
| - TOOLBOX_NAME | |
| - REGISTRY_LATEST_URL |
|
|
||
| pull: | ||
| desc: Pull our toolbox image from registry | ||
| deps: | ||
| - auth | ||
| requires: | ||
| vars: | ||
| - REGISTRY_URL_BASE |
There was a problem hiding this comment.
@gberenice REGISTRY_URL_BASE does not have a default and without a value, the REGISTRY_* vars will be broken. I added requiring here to ensure that we're passing a value from .env.taskit. Maybe there is a better way to do this?
There was a problem hiding this comment.
Hm, probably not. I don't see a way to add a check to the global vars section. LATEST_IMAGE_TAG has a default, so probably just REGISTRY_URL_BASE needs to be required. But I don't feel strong about this, and I get why we'd want to check them all.
| - auth | ||
| requires: | ||
| vars: | ||
| - REGISTRY_URL_BASE |
There was a problem hiding this comment.
Same here, one of them can be required if I get this right.
There was a problem hiding this comment.
Let's continue this conversation in the above thread 👍
lib/toolbox/Taskfile.yaml
Outdated
| install: | ||
| desc: Execute the toolbox wrapper script from geodesic, installing a toolbox start script onto the local host | ||
| summary: | | ||
| This executes the `init | bash` geodesic command, which pipes a bash script to the host machine which installs a | ||
| helper script onto the host. The helper script is used to easily start / attach the toolbox image as a container | ||
| and properly pass all of the relevant flags to docker (i.e. exposes a port, mounts $HOME to /localhost, etc.) | ||
| requires: | ||
| vars: | ||
| - TOOLBOX_NAME | ||
| - REGISTRY_LATEST_URL | ||
| cmds: | ||
| - docker run --rm {{.REGISTRY_LATEST_URL}} init | bash -s {{.TOOLBOX_NAME}} |
There was a problem hiding this comment.
better but ideally there could be a link to the script itself so we can review that before running it on our machines 😁
There was a problem hiding this comment.
@kevcube good idea, done 👍
Info
run:pullrun:buildpublishclean.env.taskitSee the loom I shared in Slack for more details.