-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make font sizes responsive to browser settings #1933
Open
clairesunstudio
wants to merge
33
commits into
develop
Choose a base branch
from
responsive-root-em
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+457
−437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 204a8c5.
clairesunstudio
changed the title
change base fonts to 100%
Make font sizes responsive to browser settings
Sep 10, 2024
This reverts commit 709d007.
arthurbaghdas
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://massgov.atlassian.net/browse/DP-34926
Reasoning behind these changes:
https://docs.google.com/document/d/1gBvtaA2pV1w0BvxvFxsS-kP8UVKRtqVlaH48wRH8b3Y/edit
New font system and mapping logic:
https://docs.google.com/spreadsheets/d/1bIB_VUNGn1kgN5M-4peeuFd0ar7do2rkCSvW83_2RdQ/edit?gid=953321770#gid=953321770
What's happening here:
Before and After
https://mayflower.digital.mass.gov/patternlab/b/develop/?p=pages-Homepage
https://mayflower.digital.mass.gov/patternlab/b/responsive-root-em/?p=pages-Homepage
Backstop report: https://output.circle-artifacts.com/output/job/020cf001-e0f1-4c84-b3e0-ff2acb1998e8/artifacts/0/backstop/reports/html/index.html
To test: