-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DP-23086 A11y when org search is not shown, it should be fully hidden for all users #1531
Open
Javi-er
wants to merge
19
commits into
develop
Choose a base branch
from
patternlab/DP-23086_organization-search-keyboard
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
919c4ac
DP-23086 Fixing keyboard navigation on organization search.
Javi-er e950456
Changelog
Javi-er 79be41d
Adjusting a11y issues
Javi-er de7fa79
focusable elements
Javi-er f24bcda
Merge branch 'develop' into patternlab/DP-23086_organization-search-k…
clairesunstudio 2e8536b
fix keyboard focus trapping
clairesunstudio 92b3b8c
reference vars for toggle class names
clairesunstudio 28c5c08
fix nav for open sub menu
clairesunstudio 0077df1
fix subnav keyboard access, trapping, and html semantic to use button…
clairesunstudio f334baf
Merge branch 'develop' into patternlab/DP-23086_organization-search-k…
clairesunstudio e5b16f9
console log cleanup
clairesunstudio ec27145
Merge branch 'patternlab/DP-23086_organization-search-keyboard' of ht…
clairesunstudio 1fdb327
include main nav non-expandable links
clairesunstudio b77a03d
cleanup unused
clairesunstudio 249910e
updating keyboard event
Javi-er f4022e5
Update packages/patternlab/styleguide/source/assets/js/modules/organi…
Javi-er e723243
marge changes
ygannett 9db1bfc
clean up comments
ygannett ea91075
Merge branch 'develop' into patternlab/DP-23086_organization-search-k…
ygannett File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.which
is deprecated and don't support IE11, please use KeyboardEvent.key and KeyboardEvent.code for new code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I just updated this.