-
Notifications
You must be signed in to change notification settings - Fork 31
toggle js-location-listing class at layout breakpoint #631
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes external review, but needs a changelog @clairesunstudio. Moving to WIP so you can do that. Once you do, move directly to Internal Review for @isaacchansky.
Sorry for the super delayed review on this. I think a simpler way to do this might be to just bind the click/mouseover/etc events once, and check the screen-width upon interaction to either do nothing or continue as normal. Rough code would look like:
This would avoid the binding/unbinding issues, and simply bind once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment, happy to chat about this on Monday!
Description
Disable the scroll up to map on mobile on location listing- this feels very jarring, and also does not add any additional info.
Related Issue / Ticket
Steps to Test
Screenshots
Additional Notes:
Help needed:
when resize down to window size < 911px, map doesn't recenter.
Impacted Areas in Application
@todo
Today I learned...