add todo

marvin-j97 · Jan 14, 2024 · 61e69ae · 61e69ae
1 parent de83bdc
commit 61e69ae
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/smoltable/src/table/mod.rs b/smoltable/src/table/mod.rs
@@ -289,6 +289,8 @@ impl Smoltable {
         })
     } */
 
+    // TODO: count thrashes block cache
+
     // TODO: unit test
     pub fn count(&self) -> fjall::Result<(usize, usize)> {
         use reader::Reader as TableReader;
@@ -328,6 +330,8 @@ impl Smoltable {
         Ok((row_count, cell_count))
     }
 
+    // TODO: GC thrashes block cache
+
     // TODO: unit test
     pub fn run_version_gc(&self) -> fjall::Result<u64> {
         use reader::Reader as TableReader;
@@ -429,6 +433,8 @@ impl Smoltable {
         Ok(deleted_cell_count)
     }
 
+    // TODO: delete row thrashes block cache
+
     // TODO: allow deleting specific columns -> DeleteRowInput, also batch + limit it?
     pub fn delete_row(&self, row_key: String) -> fjall::Result<u64> {
         let mut count = 0;