-
-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Push version to 1.0.2 for fixing a bug found by fuzzer
- Loading branch information
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63ea333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @martinus, could you please elaborate more about the bug details? For now, I see from time to time that an iteration over
svector
sometimes return some garbadge elements whensize
is less thandirect_capacity
. I'm likely using a previous version of svector, so I'd like to understand if my issue could be somehow related to the bug being fixed.63ea333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the internal method
destroy()
I forgot to callset_direct_and_size(0)
which set the size to 0 and switches svector to direct mode. I think that error happened when move-assigning a svector that's in direct mode to an svector that's in indirect mode5d1ba4f#diff-f7643ed712074dcf212096158f913b2d3dad7dd6e598949965a1eb13bbb1c0b7R532