Skip to content

Commit

Permalink
Push version to 1.0.2 for fixing a bug found by fuzzer
Browse files Browse the repository at this point in the history
  • Loading branch information
martinus committed Jul 21, 2022
1 parent 9e9b43b commit 63ea333
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.12)
project("svector"
VERSION 1.0.1
VERSION 1.0.2
DESCRIPTION " Compact SVO optimized vector for C++17 or higher"
HOMEPAGE_URL "https://github.com/martinus/svector")

Expand Down
4 changes: 2 additions & 2 deletions include/ankerl/svector.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// ┌─┐┬ ┬┌─┐┌─┐┌┬┐┌─┐┬─┐ Compact SVO optimized vector C++17 or higher
// └─┐└┐┌┘├┤ │ │ │ │├┬┘ Version 1.0.1
// └─┐└┐┌┘├┤ │ │ │ │├┬┘ Version 1.0.2
// └─┘ └┘ └─┘└─┘ ┴ └─┘┴└─ https://github.com/martinus/svector
//
// Licensed under the MIT License <http://opensource.org/licenses/MIT>.
Expand Down Expand Up @@ -30,7 +30,7 @@
// see https://semver.org/spec/v2.0.0.html
#define ANKERL_SVECTOR_VERSION_MAJOR 1 // incompatible API changes
#define ANKERL_SVECTOR_VERSION_MINOR 0 // add functionality in a backwards compatible manner
#define ANKERL_SVECTOR_VERSION_PATCH 1 // backwards compatible bug fixes
#define ANKERL_SVECTOR_VERSION_PATCH 2 // backwards compatible bug fixes

// API versioning with inline namespace, see https://www.foonathan.net/2018/11/inline-namespaces/
#define ANKERL_SVECTOR_VERSION_CONCAT1(major, minor, patch) v##major##_##minor##_##patch
Expand Down
2 changes: 1 addition & 1 deletion meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
#

project('svector', 'cpp',
version: '1.0.1',
version: '1.0.2',
license: 'MIT',
default_options : ['cpp_std=c++17', 'warning_level=3', 'werror=true'])

Expand Down

2 comments on commit 63ea333

@vstakhov
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @martinus, could you please elaborate more about the bug details? For now, I see from time to time that an iteration over svector sometimes return some garbadge elements when size is less than direct_capacity. I'm likely using a previous version of svector, so I'd like to understand if my issue could be somehow related to the bug being fixed.

@martinus
Copy link
Owner Author

@martinus martinus commented on 63ea333 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the internal method destroy() I forgot to call set_direct_and_size(0) which set the size to 0 and switches svector to direct mode. I think that error happened when move-assigning a svector that's in direct mode to an svector that's in indirect mode

5d1ba4f#diff-f7643ed712074dcf212096158f913b2d3dad7dd6e598949965a1eb13bbb1c0b7R532

Please sign in to comment.