Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check for syntax errors or linting issues in Linux/macOS build script #855

Merged

Conversation

guihkx
Copy link
Contributor

@guihkx guihkx commented Dec 8, 2022

  • CI: Check/lint the build script with bash -n and shellcheck before trying to build RSS Guard.
  • Fix warnings given by shellcheck.
  • Use set -e throughout the script to make errors more obvious.
  • Introduce the $app_id variable (Linux-only), and use it where appropriate, to reduce code duplication.
  • Use the already existing $prefix variable where appropriate, to reduce code duplication.
  • Use an array instead of a string to build the GStreamer paths for linuxdeployqt.

@guihkx
Copy link
Contributor Author

guihkx commented Dec 8, 2022

An example of how the shellcheck step can look like:

image

If you think it's going to be more annoying than helpful, I can remove it.

@martinrotter
Copy link
Owner

This is to be merged AFTER 4.2.6 release too right?

@guihkx
Copy link
Contributor Author

guihkx commented Dec 8, 2022

No, this can be merged right away (if you want). They're mostly cosmetic changes.

@guihkx
Copy link
Contributor Author

guihkx commented Dec 8, 2022

I'd actually prefer if you could merge this one before #836.

@martinrotter martinrotter merged commit b3c9777 into martinrotter:master Dec 8, 2022
@martinrotter martinrotter added this to the 4.2.6 milestone Dec 8, 2022
@martinrotter martinrotter self-assigned this Dec 8, 2022
@martinrotter martinrotter added the Type-Deployment Problem is caused by badly deployed application files. label Dec 8, 2022
@guihkx guihkx deleted the lin-mac-build-script-improvements branch December 8, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type-Deployment Problem is caused by badly deployed application files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants