Simpler Allow method version, also return * for allow-origin when supplied as * in options #9
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning:
Creation of the options object to pass to the existing Allow() made client code needlessly verbose - a simple version that supplies the three most often used CORS headers makes martini setup code much more readable and clean.
Regarding the * - it seemed unintuitive that whatever origin request header was sent was coming even though my client code was passing a * into the handler. Line 73 change remedies that condition.