Migrate to xunit v3 #839
Merged
Migrate to xunit v3 #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to xunit v3 for tests.
martincostello
added
enhancement
There was a problem hiding this comment.
Copilot reviewed 5 out of 18 changed files in this pull request and generated 1 comment.
Files not reviewed (13)
- Directory.Build.props: Language not supported
- Directory.Packages.props: Language not supported
- samples/MathsFunctions.Tests/MathsFunctions.Tests.csproj: Language not supported
- samples/MinimalApi.Tests/MinimalApi.Tests.csproj: Language not supported
- tests/AwsLambdaTestServer.Tests/MartinCostello.Testing.AwsLambdaTestServer.Tests.csproj: Language not supported
- samples/MinimalApi.Tests/ApiTests.cs: Evaluated as low risk
- samples/MinimalApi.Tests/HttpLambdaTestServer.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/AssemblyFixture.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/AwsIntegrationTests.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/Examples.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/HttpLambdaTestServer.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/ReverseFunctionWithCustomOptionsTests.cs: Evaluated as low risk
- tests/AwsLambdaTestServer.Tests/ReverseFunctionWithMobileSdkTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
tests/AwsLambdaTestServer.Tests/HttpLambdaTestServerTests.cs:21
- The use of ValueTask here might be inappropriate if DisposeAsync is expected to be awaited multiple times or if it is part of a public API. Consider reverting to Task.
public async ValueTask DisposeAsync()
tests/AwsLambdaTestServer.Tests/HttpLambdaTestServerTests.cs:31
- The use of ValueTask here might be inappropriate if InitializeAsync is expected to be awaited multiple times or if it is part of a public API. Consider reverting to Task.
public async ValueTask InitializeAsync()
| public static class LambdaTestServerCollection | ||
| { | ||
| } | ||
| public class LambdaTestServerCollection; |
There was a problem hiding this comment.
The class declaration should not end with a semicolon. It should be defined with curly braces.
Suggested change
| public class LambdaTestServerCollection; | |
| public class LambdaTestServerCollection { } |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 8 8
Lines 289 289
Branches 32 32
=======================================
Hits 280 280
Misses 3 3
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to xunit v3 for tests.