-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always cleanup cloud indexes from tests #251
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicilliar
had a problem deploying
to
cloud-tests
September 10, 2024 06:58
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
cloud-tests
September 10, 2024 06:58
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 10, 2024 07:01
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
cloud-tests
September 16, 2024 08:06
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 16, 2024 08:06
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 16, 2024 08:09
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 17, 2024 04:48
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
cloud-tests
September 17, 2024 04:48
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 17, 2024 04:49
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 17, 2024 05:01
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
cloud-tests
September 17, 2024 05:01
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 17, 2024 05:01
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 17, 2024 05:09
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 18, 2024 03:23
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
cloud-tests
September 18, 2024 03:32
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 18, 2024 07:01
— with
GitHub Actions
Error
vicilliar
had a problem deploying
to
cloud-tests
September 18, 2024 07:03
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
cloud-tests
September 18, 2024 07:10
— with
GitHub Actions
Failure
Proof that script will only clean up associated indexes (for this run).
|
Test Case:
|
vicilliar
temporarily deployed
to
cloud-tests
September 18, 2024 07:27
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 18, 2024 07:33
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
cloud-tests
September 18, 2024 07:41
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 19, 2024 05:28
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
cloud-tests
September 19, 2024 05:43
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 19, 2024 06:58
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 19, 2024 07:49
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 20, 2024 01:14
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
cloud-tests
September 20, 2024 01:27
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
py-marqo-test-suite
September 20, 2024 01:55
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
cloud-tests
September 20, 2024 01:57
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
cloud-tests
September 20, 2024 03:05
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
cloud-tests
September 20, 2024 03:30
— with
GitHub Actions
Error
vicilliar
temporarily deployed
to
cloud-tests
September 20, 2024 03:30
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
py-marqo-test-suite
September 20, 2024 03:32
— with
GitHub Actions
Failure
vicilliar
had a problem deploying
to
py-marqo-test-suite
September 20, 2024 03:41
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
cloud-tests
September 20, 2024 03:42
— with
GitHub Actions
Inactive
vicilliar
temporarily deployed
to
cloud-tests
September 20, 2024 04:16
— with
GitHub Actions
Inactive
vicilliar
had a problem deploying
to
py-marqo-test-suite
September 20, 2024 04:29
— with
GitHub Actions
Failure
vicilliar
temporarily deployed
to
py-marqo-test-suite
September 20, 2024 04:36
— with
GitHub Actions
Inactive
wanliAlex
requested changes
Sep 20, 2024
wanliAlex
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
When cloud integration test run is cancelled, indexes are not cleaned up.
What is the new behavior (if this is a feature change)?
Several test quality of life updates:
-Concurrency control. Only 1 pipeline can run at a time. Prevents overlapping indexes.
-Use last 4 digits of github run ID for test unique identifier (instead of UUID) so it can be shared between jobs.
-Run cleanup_indexes regardless of outcome of integration test.
-delete indexes script now always has
wait_for_readiness=True
-Remove
wait_for_readiness
in the cleanup section of therun_integration_tests
job. This is becausecleanup_indexes
job will always run and wait til completion. Also so the deletion time is not recorded in the test run section.-
wait_for_readiness
loop now also waits forCREATING
,MODIFYING
,DELETING
indexes, then sends a new delete request when they areREADY
orFAILED
.-Add timeouts for workflow: 1 hour for github workflow, 45 minutes for python tests.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information: