Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always cleanup cloud indexes from tests #251

Merged
merged 20 commits into from
Sep 24, 2024
Merged

Conversation

vicilliar
Copy link
Contributor

@vicilliar vicilliar commented Sep 10, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    When cloud integration test run is cancelled, indexes are not cleaned up.

  • What is the new behavior (if this is a feature change)?

Several test quality of life updates:
-Concurrency control. Only 1 pipeline can run at a time. Prevents overlapping indexes.
-Use last 4 digits of github run ID for test unique identifier (instead of UUID) so it can be shared between jobs.
-Run cleanup_indexes regardless of outcome of integration test.
-delete indexes script now always has wait_for_readiness=True
-Remove wait_for_readiness in the cleanup section of the run_integration_tests job. This is because cleanup_indexes job will always run and wait til completion. Also so the deletion time is not recorded in the test run section.
-wait_for_readiness loop now also waits for CREATING, MODIFYING, DELETING indexes, then sends a new delete request when they are READY or FAILED.
-Add timeouts for workflow: 1 hour for github workflow, 45 minutes for python tests.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@vicilliar
Copy link
Contributor Author

vicilliar commented Sep 18, 2024

Proof that script will only clean up associated indexes (for this run).

image

@vicilliar
Copy link
Contributor Author

vicilliar commented Sep 18, 2024

Test Case:

@vicilliar vicilliar merged commit cf400b4 into mainline Sep 24, 2024
3 checks passed
@vicilliar vicilliar deleted the joshua/run-cleanup-always branch September 24, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants