Large Scale Performance Tests #983
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
papa99do
reviewed
Oct 1, 2024
| @@ -0,0 +1,137 @@ | |||
| name: Large Scale Performance Tests | |||
There was a problem hiding this comment.
Why do we need a different workflow to run this? Can we reuse the locust_performance_test workflow?
The extra step can be done using lifecycle hook in the locust file, if it does not take too long to run
papa99do
reviewed
Oct 1, 2024
| # Index name from environment variable | ||
| INDEX_NAME = os.getenv('MARQO_INDEX_NAME', 'locust-test') | ||
|
|
||
| class MarqoUser(FastHttpUser): |
There was a problem hiding this comment.
We can use MarqoHttpUser which encapsulate marqo index already. You won't need to manually fire request events. We can also add telemetry support in MarqoHttpUser
papa99do
reviewed
Oct 1, 2024
| # Extract telemetry data | ||
| telemetry = response.get('telemetry', {}) | ||
| telemetry['total_time_ms'] = total_time | ||
| self.telemetry_data.append(telemetry) |
There was a problem hiding this comment.
How large is this data, would it cause out of memory issue if we run this tests for a long time with large load? Should we consider append it to a file regularly to reduce the memory footprint?
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
RaynorChavez
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Additional Test
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
New large scale performance test simulating up to 500 rps against a cloud marqo index
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements