Lexical parser modification - best effort double quote parsing #979
+106
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Any bad syntax with "" results in lexical search query being interpreted literally. The unescaped double quotes then cause a 400 from Vespa, resulting in a 500.
What is the new behavior (if this is a feature change)?
Parser logic updated: Badly formatted double quotes are treated as whitespace, terms split by this will be optional. Always tries to interpret double quotes in pairs, from left to right.
Ecape character (
\\
) is no longer removed from optional and required terms, thus no longer cause a 400 from Vespa.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, these queries used to 500 anyway.
Have unit tests been run against this PR? (Has there also been any additional testing?)
In progress
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements