Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused config #910

Open
wants to merge 2 commits into
base: mainline
Choose a base branch
from
Open

Conversation

farshidz
Copy link
Collaborator

Remove config variables from Marqo 1 that aren't used or referenced anywhere.

@@ -63,11 +62,9 @@ class EnvVars:
MARQO_ROOT_PATH = "MARQO_ROOT_PATH"
MARQO_MAX_CPU_MODEL_MEMORY = "MARQO_MAX_CPU_MODEL_MEMORY"
MARQO_MAX_CUDA_MODEL_MEMORY = "MARQO_MAX_CUDA_MODEL_MEMORY"
MARQO_EF_CONSTRUCTION_MAX_VALUE = "MARQO_EF_CONSTRUCTION_MAX_VALUE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the corresponding env var in config.py also deleted? same to MARQO_MAX_NUMBER_OF_REPLICAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants