Adding github actions file to build and push docker image to docker hub / ECR #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
requested changes
Oct 18, 2024
| - name: Configure AWS credentials | ||
| uses: aws-actions/configure-aws-credentials@v1 | ||
| with: | ||
| aws-access-key-id: ${{ secrets.AWS_EC2_GH_RUNNER_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
What is the AWS account? OpenSource or S2Search Core?
| required: false | ||
| default: 'mainline' | ||
| push_to: | ||
| description: 'image destination. Options: "ECR", "DockerHub"' |
There was a problem hiding this comment.
Make them drop down options?
There was a problem hiding this comment.
Good suggestion, Sure!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring
What is the current behavior? (You can also link to an open issue here)
Currently the same github action exists in the open_source_CI repo (https://github.com/marqo-ai/open_source_CI/blob/main/.github/workflows/build_push_img.yml). We want to move it here.
What is the new behavior (if this is a feature change)?
Behavior remains the same - the action can now be invoked from main Marqo repo
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
No
Related Python client changes (link commit/PR here)
NA
Related documentation changes (link commit/PR here)
NA
Other information:
Please check if the PR fulfills these requirements