gke deployment updates #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the helm manifest file name depends on the users random choice for names
…re not editing the setup script
…s options to either deploy or destroy the cluster, isolates output to an out dir, automatically exports MARQO_CLUSTER_IP to the env. UPDATES the README accordingly.
…LUSTER_IP is exported to so it's universal for testing purposes on all platforms, UPDADTE name of env files to avoid standard gitignore issues, UPDATE README
ali60
reviewed
Aug 6, 2024
| manifest_file_path="${OUT_DIR}/${APP_INSTANCE_NAME}_manifest_gke.yaml" | ||
| helm template "${APP_INSTANCE_NAME}" chart/marqo-kubernetes --set cloudProviderMatcher=cloud.google.com/gke-nodepool,gpu_enabled=$INSTALL_GPU,override_cuda_path=$INSTALL_GPU > "$manifest_file_path" | ||
|
|
||
| kubectl apply -f "$manifest_file_path" |
There was a problem hiding this comment.
it will take sometimes ( around 5 minutes at least) until all pods are up and health .
From this line until line 80 we need to have a while loop.
ali60
previously approved these changes
Aug 7, 2024
| gcloud container clusters get-credentials "$CLUSTER" | ||
|
|
||
| # Create vespaadmin node pools. | ||
| gcloud container node-pools create vespaadmin --cluster "$CLUSTER" --machine-type n1-standard-2 --disk-type pd-standard --disk-size=20 --num-nodes 1 |
There was a problem hiding this comment.
shouldn't these be taking the values from the manifest? ie the manifest should specify the machine-type and disk-type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the way marqo on k8s is deployed on GKE: