Expose ModelProperties as objects #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were converting the objects to dicts, this commit retains that behaviour but also exposes the underlying `ModelProperties` objects via a new `list_model_properties()` class method for clients that prefer typed objects to dicts.
ishaaq
force-pushed
the
typed-model-properties
branch
from
2e1d792
to
f250941
Compare
vicilliar
requested changes
Aug 22, 2024
src/marqo_commons/model_registry/model_properties_data/random_properties.py
Outdated
Show resolved
Hide resolved
vicilliar
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were converting the objects to dicts, this commit retains that behaviour but also exposes the underlying
ModelPropertiesobjects via a newlist_model_properties()class method for clients that prefer typed objects to dicts.