Fix bug 241 - drop color function or radius on zoom #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll or resize on merge
|
I have a custom radius function to set drop dimensions. But when I scroll or zoom the view, the size of each drop changes arbitrary. Does this commit / PR fix the radius-issue? |
|
@tobigit Yes, both custom radius and color function are fixed. My project also need custom functions which must work on every zoom/resize/drag. This fix works perfectly and I believe it can help others as well. |
|
Just wanted to mention that 2. is fixed in this pr: #259. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math.round() could identify the current drops date as duplicated incorrectly. In the demo data, many commits are very close and considered duplicated after Math.round();
drop.enter() takes care the new drops, drop.exit() takes are the removing drops. But current rendered drops are not taken care of, so color and radius are not called.