Add new version with support of aeson-2.0 and ghc-9 #69
Conversation
There was a problem hiding this comment.
Hey, I'm also actively using this library and wanting to do a similar upgrade — thanks for opening this PR! ✨
I've left a few comments about being able to support aeson-1 too, which is something I've done recently in other package upgrades.
My 2 cents would be to ditch Travis and migrate to GitHub actions instead.
It's really easy to set up and there is a great reference at https://kodimensional.dev/github-actions.
twilio.cabal
Outdated
| @@ -84,11 +84,11 @@ library | |||
| Twilio.UsageTrigger, | |||
| Twilio.UsageTriggers | |||
| hs-source-dirs: src | |||
| build-depends: aeson >=0.8 && <0.10 || >=0.11, | |||
| build-depends: aeson >=2.0, | |||
There was a problem hiding this comment.
| build-depends: aeson >=2.0, | |
| build-depends: aeson >= 0.11 && <1.6 || >=2.0 && <2.2,, |
There was a problem hiding this comment.
Also, text ==1.*, would be good to update to text ==1.* || ==2.0.*, to support the new 2.0 release.
src/Twilio/Tokens.hs
Outdated
| @@ -21,7 +21,7 @@ import Control.Error.Safe | |||
| import Control.Monad | |||
| import Control.Monad.Catch | |||
| import Data.Aeson | |||
| import qualified Data.HashMap.Strict as HashMap | |||
| import qualified Data.Aeson.KeyMap as KeyMap | |||
There was a problem hiding this comment.
| import qualified Data.Aeson.KeyMap as KeyMap | |
| #if MIN_VERSION_aeson(2,0,0) | |
| import qualified Data.Aeson.KeyMap as KeyMap | |
| #else | |
| import qualified Data.HashMap.Strict as KeyMap | |
| #endif |
If we're "ok" with enabling CPP, we can support both aeson 1 and 2 which might be helpful while people are still migrating over.
This would also require {-# LANGUAGE CPP #-} at the top of the file.
| @@ -43,14 +42,14 @@ class FromJSON b => List a b | a -> b where | |||
| getList :: a -> [b] | |||
|
|
|||
| -- | The plural name for the items in the 'List'. | |||
| getPlural :: Const Text (a, b) | |||
There was a problem hiding this comment.
Here I think you could do something like:
#if MIN_VERSION_aeson(2,0,0)
#else
type Key = Text
#endif
|
@jonathanlking thank you for your review! I applied your suggestions and tested the build (only one build) on a couple of stack resolvers, each with different versions of aeson and text. It seems to be compiling correctly. Regarding Travis, I totally agree with you, but I'm not sure if the migration should be done in this pull request. |
Hi!
I'm actively using this library, and we're planning to migrate our project to ghc9.
Since there is no open PR with similar changes, I decided to send mine.
I think there are still some questions needs to be resolved, for example updating of travis.ci configuration, and removal of Eq instance from Network.HTTP.Client.Response.
But overall, I think this version should work fine.
Any suggestions are welcome, and I'll try to fix them asap.