Skip to content

Use htmlmin2 instead of htmlmin#29

Merged
pavelzw merged 5 commits intomainfrom
htmlmin2
Mar 18, 2025
Merged

Use htmlmin2 instead of htmlmin#29
pavelzw merged 5 commits intomainfrom
htmlmin2

Conversation

@pavelzw
Copy link
Contributor

@pavelzw pavelzw commented Mar 18, 2025

closes #28

Copy link
Contributor Author

@pavelzw pavelzw Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lockfile diff:

Dependencies

Explicit dependencies
Dependency1 Before After Change Environments
htmlmin2 0.1.13 Added all
marimo 0.11.21 Added py313 on all platforms
mkdocs 1.6.1 Added py313 on all platforms
mypy 1.15.0 Added py313 on all platforms
pytest 8.3.5 Added py313 on all platforms
python 3.13.2 Added py313 on all platforms
Implicit dependencies
Dependency1 Before After Change Environments
_libgcc_mutex 0.1 Added py313 on linux-64
_openmp_mutex 4.5 Added py313 on {linux-64, linux-aarch64}
anyio 4.9.0 Added py313 on all platforms
bzip2 1.0.8 Added py313 on all platforms
ca-certificates 2025.1.31 Added py313 on all platforms
click 8.1.8 Added py313 on all platforms
colorama 0.4.6 Added py313 on all platforms
docutils 0.21.2 Added py313 on all platforms
editables 0.5 Added py313 on all platforms
exceptiongroup 1.2.2 Added py313 on all platforms
ghp-import 2.1.0 Added py313 on all platforms
h11 0.14.0 Added py313 on all platforms
hatchling 1.27.0 Added py313 on all platforms
idna 3.10 Added py313 on all platforms
importlib-metadata 8.6.1 Added py313 on all platforms
iniconfig 2.0.0 Added py313 on all platforms
itsdangerous 2.2.0 Added py313 on all platforms
jedi 0.19.2 Added py313 on all platforms
jinja2 3.1.6 Added py313 on all platforms
ld_impl_linux-64 2.43 Added py313 on linux-64
ld_impl_linux-aarch64 2.43 Added py313 on linux-aarch64
libcxx 19.1.7 Added py313 on {osx-64, osx-arm64}
libexpat 2.6.4 Added py313 on all platforms
libffi 3.4.6 Added py313 on {linux-64, linux-aarch64, osx-64, win-64}
libffi 3.4.2 Added py313 on osx-arm64
libgcc 14.2.0 Added py313 on {linux-64, linux-aarch64}
libgcc-ng 14.2.0 Added py313 on {linux-64, linux-aarch64}
libgomp 14.2.0 Added py313 on {linux-64, linux-aarch64}
liblzma 5.6.4 Added py313 on all platforms
libmpdec 4.0.0 Added py313 on all platforms
libsqlite 3.49.1 Added py313 on all platforms
libstdcxx 14.2.0 Added py313 on {linux-64, linux-aarch64}
libuuid 2.38.1 Added py313 on {linux-64, linux-aarch64}
libzlib 1.3.1 Added py313 on all platforms
markdown 3.6 Added py313 on all platforms
markupsafe 3.0.2 Added py313 on all platforms
mergedeep 1.3.4 Added py313 on all platforms
mkdocs-get-deps 0.2.0 Added py313 on all platforms
mypy_extensions 1.0.0 Added py313 on all platforms
narwhals 1.31.0 Added py313 on all platforms
ncurses 6.5 Added py313 on {linux-64, linux-aarch64, osx-64, osx-arm64}
openssl 3.4.1 Added py313 on all platforms
packaging 24.2 Added py313 on all platforms
parso 0.8.4 Added py313 on all platforms
pathspec 0.12.1 Added py313 on all platforms
pip 25.0.1 Added py313 on all platforms
platformdirs 4.3.6 Added py313 on all platforms
pluggy 1.5.0 Added py313 on all platforms
psutil 7.0.0 Added py313 on all platforms
pycrdt 0.11.1 Added py313 on all platforms
pygments 2.19.1 Added py313 on all platforms
pymdown-extensions 10.14.3 Added py313 on all platforms
python-dateutil 2.9.0.post0 Added py313 on all platforms
python_abi 3.13 Added py313 on all platforms
pyyaml 6.0.2 Added py313 on all platforms
pyyaml-env-tag 0.1 Added py313 on all platforms
readline 8.2 Added py313 on {linux-64, linux-aarch64, osx-64, osx-arm64}
ruff 0.11.0 Added py313 on all platforms
six 1.17.0 Added py313 on all platforms
sniffio 1.3.1 Added py313 on all platforms
starlette 0.46.1 Added py313 on all platforms
tk 8.6.13 Added py313 on all platforms
tomli 2.2.1 Added py313 on all platforms
tomlkit 0.13.2 Added py313 on all platforms
trove-classifiers 2025.3.13.13 Added py313 on all platforms
typing_extensions 4.12.2 Added py313 on all platforms
tzdata 2025a Added py313 on all platforms
ucrt 10.0.22621.0 Added py313 on win-64
uvicorn 0.34.0 Added py313 on all platforms
vc 14.3 Added py313 on win-64
vc14_runtime 14.42.34438 Added py313 on win-64
vs2015_runtime 14.42.34438 Added py313 on win-64
watchdog 6.0.0 Added py313 on all platforms
websockets 15.0.1 Added py313 on all platforms
yaml 0.2.5 Added py313 on all platforms
zipp 3.21.0 Added py313 on all platforms
htmlmin 0.1.12 Removed {default, docs, py310, py311, py312, py39} on all platforms

Footnotes

  1. Bold means explicit dependency. 2

@pavelzw pavelzw marked this pull request as ready for review March 18, 2025 13:10
@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 18, 2025

hmm one python 3.13 test is failing

E       assert """
<marimo-cell-output><pre style="font-size: 12px">World</pre></marimo-cell-output>
"""
in 
"""
<marimo-island data-app-id=main data-cell-id=Hbol data-reactive=true><marimo-cell-output><pre style="font-size: 12px">&#x27;World&#x27;</pre></marimo-cell-output><marimo-cell-code hidden>\'World\'</marimo-cell-code></marimo-island>
"""

@mscolnick
Copy link
Contributor

@pavelzw it looks like the test might be buggy. there are quotes that maybe previously were not preserved, but not correctly are. we could either remove the quotes in test case, or update the assertion

@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 18, 2025

i adjusted the test and skipped it for python <3.13

@pavelzw pavelzw requested a review from mscolnick March 18, 2025 15:38
@pavelzw
Copy link
Contributor Author

pavelzw commented Mar 18, 2025

any other comments @mscolnick? otherwise i would merge this PR and create a new release :)

Copy link
Contributor

@mscolnick mscolnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! nice work

@pavelzw pavelzw merged commit 088370a into main Mar 18, 2025
14 of 15 checks passed
@pavelzw pavelzw deleted the htmlmin2 branch March 18, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for py3.13

2 participants