Add signature comparison test#966
Open
InfiniteSwerve wants to merge 2 commits intocrypto-test-hold-11from
Open
Add signature comparison test#966InfiniteSwerve wants to merge 2 commits intocrypto-test-hold-11from
InfiniteSwerve wants to merge 2 commits intocrypto-test-hold-11from
Conversation
InfiniteSwerve
force-pushed
the
crypto-test-hold-11
branch
from
b9917fc to
39c9eb6
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-12
branch
from
1c8ed4a to
7e5b293
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-11
branch
from
39c9eb6 to
f0482d1
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-12
branch
from
7e5b293 to
ff02dea
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-11
branch
from
f0482d1 to
87e4414
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-12
branch
from
ff02dea to
330f10b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends
Do not merge unless target is main
Problem
We want to ensure that the derived signature comparison function matches that of Tezos'
Solution
We sort a list of signatures with Tezos' and Deku's compares, then check their equality.
note: This test fails because of PR #962. This is OK, and will be fixed once all the tests have been migrated.