-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the class usable through Composer and add a small test #8
base: master
Are you sure you want to change the base?
Conversation
Awesome, would love to see this on Packagist! |
I've changed the test to use some free currency converter API. They don't seem to complain with the few tests I did. Also, I already created the package on packagist, I'll update the repo and transfer you the ownership if you want as soon as the code is merged here. Also, feel free to add more info about you on the composer.json file. |
Okay, cool! I'm gonna put all composer files in their own directory instead of the main one though, since not everyone uses composer(I don't most of the time). |
Awesome, I just rebased the branch against your latest version (including the fix for #9 ), let me know if you need anything else and thanks to you on the first place for building this class. |
This should get merged |
I agree. I need to update the composer files and tests first though. I'll merge it by next week. |
I can try to update the branch with your latest changes, I'll see if I can have time this week. Once you do, I'll update packagist as well to point to your repo. |
I forked this project and turned it into something a little different. I would much apreciate comments/ideas. Let me know what you think about the new interface |
Hmm, I definitely like the idea of being able to append stuff(options, headers, etc...) to the ones already set! Gonna use your fork as inspiration and split up the individual requests and the main controller in an upcoming version so we can do this in the simplest way possible. |
@marcushat you don't have to use the magic functions, they just provide a nice way of doing But if you prefer getters/setters, they are all available, and documented in the Request interface |
Alright cool. I'll add all this functionality to the next version, v3.0(or some other later version)! Coming Soon! |
deae2b8
to
a61982c
Compare
I've moved the class to a folder structure following PSR-0 so people can use this class through composer. Feel free to add more info on the composer.json and then we can create the package on packagist.org so people can download and use this great library.