Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add STARTTLS #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add STARTTLS #3

wants to merge 2 commits into from

Conversation

thallian
Copy link

@thallian thallian commented Sep 8, 2017

This adds the possibility to connect to an ldap server with STARTTLS.

I am not quite sure if there is a better way of doing this but I found nothing else that worked.

The `ldap_starttls` configuration key is added. If it is set to `True`
the ldap connection tries to use STARTTLS.
@marcoh00
Copy link
Owner

Hi! Thanks for caring about the project and even doing some work to make it better :) !

I see the code can call "bind" multiple times now when using STARTTLS. As I don't know a whole lot about ldap3 myself, did you do that on purpose? Do you know which other implications it can have? If not, it would be super-nice to do a little update to the program flow, so it'll bind only once. I will happily merge it then. If yes, please just say so, I am always willing to learn new things and merge it anyway ;)

Thanks again!

@thallian
Copy link
Author

Sorry for the long delay. In the meantime I changed my architecture and no longer use STARTTLS, so I can't really test it now.

Looking at the code now, I'd say it should be possible to call bind only once but I have to test this. Allow me a bit of time to set up my testing environment again, then I can give you a definite answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants