Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple LDAP servers #12

Merged
merged 5 commits into from
Jun 18, 2020
Merged

Support for multiple LDAP servers #12

merged 5 commits into from
Jun 18, 2020

Conversation

holczert
Copy link

Hi,

we are using Radicale with ldap auth, and we have multiple LDAP servers for HA. This modification let us automatically switch between the servers if one is down (using the ldap3 ServerPool concept). Please merge it if you find it potentially useful for others.

@marcoh00 marcoh00 changed the base branch from master to 2 June 17, 2020 21:06
@marcoh00
Copy link
Owner

marcoh00 commented Jun 17, 2020

Hi!

The master branch will probably soon be updated to host a different ldap plugin compatible with Radicale 3 (see #11), so I changed the target branch to 2.

This seems like a useful feature to have and it doesn't look like it would likely break anything, so I'd be happy to merge it. Could you please also update the README file to reflect the possibility of adding multiple servers? Just a comment or something :)

Thanks a lot!

@holczert
Copy link
Author

Changing to branch 2 is a good idea, I totally agree.
I have already added a comment to the README in the ldap_url description: (multiple servers can be separated by spaces). Do you think something more explicit or an example needed?

@marcoh00
Copy link
Owner

Sorry, I missed that. Looks good, thanks a lot :)

@marcoh00 marcoh00 merged commit 3f9e1bf into marcoh00:2 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants