Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radicale 3 support #11

Open
nebulade opened this issue May 26, 2020 · 5 comments · May be fixed by #13
Open

Radicale 3 support #11

nebulade opened this issue May 26, 2020 · 5 comments · May be fixed by #13

Comments

@nebulade
Copy link

Hi,

we at Cloudron are in the process of updating our app package to Radicale v3 and thus were hoping to use this plugin for user integration, however it appears the Radicale auth plugin interface has slightly changed. I have created a custom plugin within our app package repo at https://git.cloudron.io/cloudron/radicale-app/-/tree/master/radicale_cloudron_ldap_auth

It would be great if we could somehow merge ours into this plugin to join forces.
Is there any interest within this project to support Radicale 3 and thus would a pull request with the fixes have any chances?

Thanks!

@marcoh00
Copy link
Owner

marcoh00 commented Jun 4, 2020

Hi!

I'm always happy to merge pull requests which improve the project. Please note that this plugin is mostly in maintenance mode, which means I haven't touched the code in ages! I'm okay with maintaining the repository though and help new contributors where I can.

In case you are actively using and maintaining this I could also imagine transferring the ownership of this repo.

@nebulade
Copy link
Author

Thanks for your answer. I was taking a quick look how I could create a pull-request for radicale 3 support, however it seems their plugin system has diverged too much unfortunately. Just taking a look at the entrypoint in setup.py reveals major differences https://git.cloudron.io/cloudron/radicale-app/-/blob/master/radicale_cloudron_ldap_auth/setup.py#L3 vs https://github.com/marcoh00/radicale-auth-ldap/blob/master/setup.py#L3

Do you have an idea how this could be done to still keep your repository as the main repo to avoid confusion for users?
For example master branch could start supporting radicale 3 and a radicale 2 branch is created?

@marcoh00
Copy link
Owner

marcoh00 commented Jun 16, 2020

I created a 2-final tag for users still interested in the Radicale 2 plugin. Feel free to submit your pull request.

Are you the original author of the v3 plugin or is it based on someone else's work? Anyhow, it would be nice if you could clarify authorship and the license of your code inside your setup.py and inside a comment at the top of the source file. Even though this repository had no LICENSE file until yet, it would be welcome as well :)

@nebulade
Copy link
Author

Yes the code is written by me, but the original version was inspired by your code, thus the mostly matching config variable names. Which license would you prefer to be there?

Sorry that progress on this is slow, hopefully I get around doing this this week.

nebulade added a commit to cloudron-io/radicale-auth-ldap that referenced this issue Jun 22, 2020
@nebulade nebulade linked a pull request Jun 22, 2020 that will close this issue
@sphakka
Copy link

sphakka commented Sep 19, 2023

Hi!
What's the status? I'd really like to test it with Radicale 3.1.8 (Debian) :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants