extend splitHaplotype with fastq output option #2147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly straightforward changes to allow splitHaplotype to take a
-fastq
flag to print out triobinned fastq reads. Canu may not use the quality values in assembly, but as the primary triobinning program, this allows users to bin fastq reads directly instead of a slower "triobin fasta -> get read IDs -> extract fastq" process.I tested this on my data for both binning fasta (normal) and fastq (with
-fastq
) and both appear to be working correctly.Not sure on the memory implications of storing the quality values, could optionally uncomment this line
so only if the output is fastq do you load in the quals. But if the memory is initialised at
_quals = new simpleString [_maxReads];
then this may not do much.Also I reused the simpleString structure, which required casting to and from unsigned to signed char but this shouldn't be problematic.