Better --noSplit
#71
Closed
Better --noSplit
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkille
force-pushed
the
better-nosplit
branch
from
eff3d64
to
385edae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable unbiased Jaccard estimates, the
--noSplitoption would use the same sketch size for each query, regardless of length.This PR makes a tradeoff which results in potential bias for the Jaccard prediction but more accurate mappings for queries that are longer than the segment length (default 5kbp). The previous behavior is still obtainable with
--unbiasedNoSplit.Keeping closed for now, as a better solution is likely just to use a larger sketch size.