Adding telemetry #144
Merged
Adding telemetry #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebstryczek
reviewed
Dec 10, 2024
sebstryczek
approved these changes
Dec 10, 2024
|
So far so good, I am starting adding registration to modules |
sebstryczek
reviewed
Dec 10, 2024
src/Telemetry.ts
Outdated
Comment on lines
39
to
41
| registerModule(name: string, version: string) { | ||
| this.registeredModules.push({ name, version }); | ||
| } |
There was a problem hiding this comment.
So I wonder about registration from CustomLayer.
The map instance is available in onAdd method, so it will be called for each instance of the layer.
We can make run it only once but then it won't be called for multiple maps.
So we have two options:
- Saving registered map ids and check if it was already registered.
- Check here, if the module was already registered.
wdyt?
There was a problem hiding this comment.
Good point! As discussed, I think this should not be dealt with by modules but rather internally in the SDK. So I'll just add this logic of avoiding duplicates while still being able to spot if a project is using two different versions of a plugin.
Good catch!
sebstryczek
added a commit
that referenced
this pull request
Jan 6, 2025
* Replace transform calls by map calls * Some fix for globe compatibility * Adding projection control and map instance logic (#132) * adding the projection control * wip * fixed the projection control animation * Map class now has a better projection management * Projection control is now using the Map methods * linting * Projection documentation * isGlobeprojection to isGlobeProjection * udpate readme with new FOV built-in function * update maplibre * release canditate version number * update to ML v5 pre 7 and newer Client lib * update to maplibre 5.0.0-pre.8 * RD-369_maplibre-pre9 (#145) * Update maplibre to 5.0.0.pre9 * Add globe examples * Adding telemetry (#144) * Adding telemetry * update telemetry endpoint * now using a Set * Bump version * RD-492_maplibre-v5.0.0-pre10 (#149) * Update code for using maplibre v5.0.0-pre10 * Update examples * Bump version * v3.0.0_RD-401_maplibre-v5.0.0 (#150) * Update dependencies * Update demos * Update changelog * Make biome happy * Improve development experience (fix dev mode) * Update icons * Split vite config files --------- Co-authored-by: Jonathan Lurie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RD-452
RD-454
RD-455
From each module, the Telemetry feature should be used as such: