Adding projection control and map instance logic #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrsloup
requested changes
Nov 4, 2024
readme.md
Outdated
Comment on lines
355
to
369
| ## Field of view (FOV) | ||
| The internal camera has a default vertical field of view [*(wikipedia)*](https://en.wikipedia.org/wiki/Field_of_view) of a wide ~36.86 degrees. In globe mode, such a large *FOV* reduces the amount of the Earth that can be seen at once and exaggerates the central part, comparably to a fisheye lens. In many cases, a narrower *FOV* is preferable. Here is how to update if: | ||
|
|
||
| ```ts | ||
| // Ajust de FOV, with values from 1 to 50 | ||
| map.transform.setFov(10); | ||
| map.redraw(); | ||
| ``` | ||
| > 📣 *__Note:__* with the Mercator projection, it is possible to set a FOV of `0`, which yields a true orthographic projection [*(wikipedia)*](https://en.wikipedia.org/wiki/Orthographic_projection), but the globe projection does not allow this. | ||
|
|
||
| Here is a table of FOV comparison: | ||
| | 01° | 10° | 20° | 30° | 40° | 50° | | ||
| | :--------: | :-------: |:-------: |:-------: |:-------: |:-------: | | ||
| |  |  |  |  |  |  | | ||
|
|
There was a problem hiding this comment.
I'm thinking whether this is not too specific and maybe does not need to be documented directly in the readme? (Especially since it adds several megabytes of data to the repo.)
There was a problem hiding this comment.
Also, there is now a public method to adjust the FoV nicely: maplibre/maplibre-gl-js@d3f2bca
There was a problem hiding this comment.
I've update the FOV function with the new built-in. As per removing this section entirely, I think now that's it's here and it's not going to be written anywhere else in probably at least the next few months, we better keep it.
petrsloup
reviewed
Nov 4, 2024
Draft
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is adding the projection control as well as Map class methods to address the projection change in an easier and more complete way than Maplibre
This also include the readme documentation about projections