-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sccache and vcpkg built-in GitHub Actions support in node-ci #2970
base: main
Are you sure you want to change the base?
Conversation
a99dd7e
to
86c6c79
Compare
81f412f
to
ff0d5d7
Compare
Shellcheck is reporting some issues: .github/workflows/node-ci.yml:222:9: shellcheck reported issue in this script: SC1009:info:6:3: The mentioned syntax error was in this simple command [shellcheck] You can install pre-commit locally with
|
d909760
to
2b2a386
Compare
Yeah, I discovered shellcheck does not support PowerShell scripts, so I converted everything to |
2b2a386
to
acdc18e
Compare
77357f5
to
57d6b98
Compare
|
9c82789
to
60239de
Compare
Okay, resolved with a simple |
…3D files version to 24.2.5
60239de
to
ae2396f
Compare
After successful tests, I'm updating
node-ci.yaml
to use the enhancements ofwindows-ci.yaml
to have better cache control and sharing with other workflows. Hopefully this will optimize the cache use and will speed-up the workflow in Windows.