Add element to display Javascript errors#68
Open
EtienneDesticourt wants to merge 1 commit intomapbox:masterfrom
Open
Add element to display Javascript errors#68EtienneDesticourt wants to merge 1 commit intomapbox:masterfrom
EtienneDesticourt wants to merge 1 commit intomapbox:masterfrom
Conversation
|
Unfortunately this conflicts now, but it would be great to have! Also #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya,
As we discussed in the TokenError PR I've implemented a modal element to display Javascript errors in the style of python errors. I'll add another commit to clean up the code & remove whitespace, opening the PR now so we can discuss the next steps.
It looks like this:

@ryanbaumann
Sounds complicated, is it really worth it? The simplest way to do it would be to add a verbose parameter to MapViz, otherwise I'll see if we can register a JS variable in the Jupyter scope since the JS of the cell is regenerated every time it's run.
How would you go about distinguishing the errors that need to be displayed as errors, or warnings, or not all? Do they have distinct characteristics (specific word in error message, etc...) in the mapbox.js library?