Replace overridable icon paths with overridable icon components #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pichfl
force-pushed
the
icon-component
branch
from
eaffb61 to
22d80cb
Compare
pichfl
force-pushed
the
icon-component
branch
5 times, most recently
from
13d478e to
853a492
Compare
pichfl
force-pushed
the
icon-component
branch
from
853a492 to
d2e5c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes better use of Ember structure and allows users to replace the icons with more complex SVGs or even emoji. The HTML structure for the message component could be simplified further, but a dynamic
{{component}}helper invocation would be difficult to use with Embroider, so this is actually more sensible at the time.I already redrew and adjusted the icons so they fit a common theme and each type has it's own icon.
By doing the type comparison inside the component class, I was able to drop the included (but undocumented)
{{equal}}helper from the project, in fact this might have been unused for some time now.Further refactoring of the DOM structure is advised, but will happen in the next PR.
This can replace #268