Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined nonces should be equal in IdToken processing #1286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdrianFarmadin
Copy link

Nonces are compared with strict equality claims.nonce !== savedNonce
If savedNonce is not defined then the default value is null.
If nonce attribute is missing on claims object, then the default value is undefined.

With strict equality this will cause an error. The savedNonce should be initialized with undefined

@wjehring
Copy link

@manfredsteyer any chance you could take a look at this please?

I'm trying to use fetchTokenUsingGrant, and since there's no way to pass a skipNonceCheck like in some other calls, it's throwing because there's no nonce in the id token.

Happy to help out if there's anything I can assist with!

@L-X-T L-X-T force-pushed the master branch 4 times, most recently from a54ea92 to 078415b Compare December 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants