Fix replacing substring of params in search query #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xhofleer
changed the title
Xhofleer
commented
Apr 25, 2022
Comment on lines
-1752
to
-1757
| .replace(/^\?&/, '?') | ||
| .replace(/&$/, '') | ||
| .replace(/^\?$/, '') | ||
| .replace(/&+/g, '&') | ||
| .replace(/\?&/, '?') | ||
| .replace(/\?$/, '') + |
There was a problem hiding this comment.
The new way of matching will result in less situations that can break the format of the URL that's why these replace are not needed anymore.
|
@GeorgeHarbers I think your recent updates make it so your private AWS and GitHub Workflow code became part of the PR to this upstream library, I presume that was not intended? I don't see any immediate secrets being leaked when scanning the changes in the PR, but I recommend double checking regardless. |
|
Correct, my bad. I will restore it. |
L-X-T
force-pushed
the
master
branch
4 times, most recently
from
a54ea92 to
078415b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tryLoginCodeFlow in the oAuth-service.ts clears the hash after login. The code removes the following parameters from the search query: code, scope, state and session_state. The regex that was used to remove these params was breaking different params that end on the same string.
e.g. if the param "zipcode=xxx" was used in the search query the string "code=xxx" was removed and the URL was not valid anymore.
"http://localhost:4300?zipcode=10115&consumption=2500"
Was resulting in
"http://localhost:4300?zip&consumption=2500"
In this PR I changed the regex to only remove the parameter if it's a total match.