Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates capa_explorer.py, enabling the user to choose b/w having bookmarks & comments. #2029
base: master
Are you sure you want to change the base?
updates capa_explorer.py, enabling the user to choose b/w having bookmarks & comments. #2029
Changes from 1 commit
fe2a208
07fc637
94c9ada
e57ad9b
1ffa18c
0491470
e90b303
9e2984c
e7d67c1
b7c5267
8cff831
c71e1bf
869c3bd
acee34e
f26a806
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script modifies a Ghidra database by adding:
We want our changes here to enable users to select any number of these options when running this script. Presently, the
label_matches
method creates the "capa" namespace, corresponding namespace entries, and pre/plate-comments. We need to modify thelabel_matches
method to account for the user's selection and I'd recommend passing new boolean arguments to thelabel_matches
method to implement this. Creating a new "capa" namespace and corresponding namespace entries should be grouped as one option, likewise with setting pre/plate-comments.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mike-hunhoff
So just to clarify for the adding comments based on the user input, we want to just have a boolean default and pass an argument based on what the user wants in the function call within the if-else statement.
and, if I understand right you'd like separate options for creating the 'capa' namespace and setting pre/plate comments, even though the namespace might be used for comments. Is that correct?
Can you elaborate on the reasoning behind separate options? Is it for user flexibility or maybe workflow reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a step back, it may be easier to understand the requested changes by reviewing the README's UI integration section.
capa_explorer.py does three things:
We'd like to give user's an option to choose which of these three things are executed based on their needs/workflow. For example, a user may be interested in options 1 and 3 while not wanting 100s of comments added to their Ghidra database by option 2.