Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cmake and libuv port #54

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Conversation

Dennisbonke
Copy link
Member

This PR adds the following ports:

  • libuv, a direct dependency of cmake,
  • cmake, the successor to the old-school configure scripts.

This PR is part of #33
This PR is blocked on #53
This PR is blocked on managarm/xbstrap#24
This PR is blocked on a new xbstrap release
This PR is blocked on managarm/mlibc#158
This PR is blocked on managarm/mlibc#159
This PR is blocked on managarm/mlibc#163
This PR is blocked on managarm/mlibc#164
This PR is blocked on a new mlibc release

Copy link
Member

@qookei qookei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine apart from the the comments.

Some more notes:

  • uv__sendmmsg and uv__recvmmsg is only called if defined(__linux__) || defined(__FreeBSD__) || defined(__FreeBSD_kernel__).
  • uv__preadv and uv__pwritev is called if !defined(HAVE_PREADV) && defined(__linux__) (HAVE_PREADV means it's one of {Dragon,Free,Open,Net}BSD).
  • uv__dup3 is never called (only exists in linux-syscall.{c,h}), on a side note, dup3 is only called if it's Linux, NetBSD or FreeBSD and otherwise dup2 is used.
  • uv__fs_copy_file_range is only called if defined(__linux__) and is emulated otherwise.
  • as already commented, uv__statx is only used if defined(__linux__).
  • uv__getrandom is only used when defined(__linux__).

Also, I am unsure about the copyright on the new managarm-* files.

patches/libuv/0001-Add-Managarm-support.patch Outdated Show resolved Hide resolved
patches/libuv/0001-Add-Managarm-support.patch Outdated Show resolved Hide resolved
patches/libuv/0001-Add-Managarm-support.patch Outdated Show resolved Hide resolved
patches/libuv/0001-Add-Managarm-support.patch Outdated Show resolved Hide resolved
Signed-off-by: Dennisbonke <[email protected]>
@qookei
Copy link
Member

qookei commented Sep 18, 2020

LGTM, will merge after everything this is blocked on is done

@Dennisbonke Dennisbonke merged commit 254b51b into managarm:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants