Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: actions/checkout@v4 #4

Merged
merged 3 commits into from
Oct 18, 2024
Merged

update: actions/checkout@v4 #4

merged 3 commits into from
Oct 18, 2024

Conversation

ksaito422
Copy link
Contributor

@ksaito422 ksaito422 commented Oct 9, 2024

Due to the end of support for Node.js 16, I would like to update the actions to use Node.js 20.

see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

use Node.js 20 as Node.js 16 is end-of-life
@ksaito422 ksaito422 marked this pull request as ready for review October 9, 2024 00:09
@ksaito422 ksaito422 force-pushed the update-actions branch 2 times, most recently from d8941e9 to 6f2ecf0 Compare October 17, 2024 12:47
@ksaito422
Copy link
Contributor Author

ksaito422 commented Oct 17, 2024

@mame A warning has been introduced in ruby/ruby#10428, indicating that ostruct will become a bundled gem starting from Ruby 3.5.

Upon checking the CI error logs, I saw this warning and added the dependency to the gemspec:

output from parser-cmd (stderr):
  /opt/hostedtoolcache/Ruby/3.3.5/x64/lib/ruby/3.3.0/json/common.rb:3: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
  You can add ostruct to your Gemfile or gemspec to silence this warning.

After making this change, the CI passed successfully, so I believe this resolves the necessary updates for GitHub Actions.

I would appreciate it if you could review the changes again. Thank you for your time 🙏

@ksaito422 ksaito422 requested a review from mame October 17, 2024 13:30
@mame
Copy link
Owner

mame commented Oct 17, 2024

@ksaito422 Thank you for the PR, but please do not add a dependency to ostruct. The perfect_toml gem itself does not depend on the ostruct gem. Only the test script does. I guess adding gem "json", ">= 2.7.2" to Gemfile will solve the issue.

@ksaito422
Copy link
Contributor Author

@ksaito422 Thank you for the PR, but please do not add a dependency to ostruct. The perfect_toml gem itself does not depend on the ostruct gem. Only the test script does. I guess adding gem "json", ">= 2.7.2" to Gemfile will solve the issue.

Thanks for the advice. I had overlooked the dependency there.
I have addressed it, please check.

since this is a gem that depends on the test.
@mame mame merged commit 6efc8bc into mame:main Oct 18, 2024
4 checks passed
@mame
Copy link
Owner

mame commented Oct 18, 2024

Thanks!

@ksaito422 ksaito422 deleted the update-actions branch October 18, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants